Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts TombEngine (TEN) level compilation to emit normalized color values, addressing the longstanding issue where exported colors were effectively in a 0.0–2.0 range instead of 0.0–1.0.
Changes:
- Normalizes room ambient light, vertex colors, static mesh tint, and dynamic light colors for TombEngine export.
- Normalizes item/static instance color tint written into TombEngine item tables.
- Updates custom-vertex lighting normalization logic to target a 0..1 output range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| TombLib/TombLib/LevelData/Compilers/TombEngine/Rooms.cs | Applies multiple color normalization steps for room geometry, ambient, static meshes, vertex colors, and dynamic lights in TEN export. |
| TombLib/TombLib/LevelData/Compilers/TombEngine/LevelCompilerTombEngine.cs | Normalizes exported item tint color for TEN items table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the old bug about the 0.0f - 2.0f color range. After merging this pull request, TE will emit colors in 0.0f - 1.0f range for TEN target.